-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Allow broker to handle non-recoverable schema error only if SchemaLedgerForceRecovery flag is enabled #23428
Conversation
…y if SchemaLedgerForceRecovery flag is enabled
@rdhabalia Please add the following content to your PR description and select a checkbox:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23428 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.74%
- Complexity 32624 34447 +1823
============================================
Files 1877 1950 +73
Lines 139502 147718 +8216
Branches 15299 16402 +1103
============================================
+ Hits 102638 109782 +7144
- Misses 28908 29449 +541
- Partials 7956 8487 +531
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great improvements, @rdhabalia
Closed and reopened to get Pulsar CI to run with fix PR #23431 |
Motivation
We have made broker resilient during non-recoverable schema error with PR: #23395
However, there is discussion to make it only if
SchemaLedgerForceRecovery
enabled. so, this PR enables schema lost recovery only if force flag is enabled.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: