Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Allow broker to handle non-recoverable schema error only if SchemaLedgerForceRecovery flag is enabled #23428

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Oct 9, 2024

Motivation

We have made broker resilient during non-recoverable schema error with PR: #23395
However, there is discussion to make it only if SchemaLedgerForceRecovery enabled. so, this PR enables schema lost recovery only if force flag is enabled.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

…y if SchemaLedgerForceRecovery flag is enabled
@rdhabalia rdhabalia added this to the 4.0.0 milestone Oct 9, 2024
@rdhabalia rdhabalia self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

@rdhabalia Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-not-needed Your PR changes do not impact docs doc-label-missing labels Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (bbc6224) to head (d0b64de).
Report is 661 commits behind head on master.

Files with missing lines Patch % Lines
...rg/apache/pulsar/broker/service/AbstractTopic.java 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23428      +/-   ##
============================================
+ Coverage     73.57%   74.31%   +0.74%     
- Complexity    32624    34447    +1823     
============================================
  Files          1877     1950      +73     
  Lines        139502   147718    +8216     
  Branches      15299    16402    +1103     
============================================
+ Hits         102638   109782    +7144     
- Misses        28908    29449     +541     
- Partials       7956     8487     +531     
Flag Coverage Δ
inttests 27.69% <0.00%> (+3.11%) ⬆️
systests 24.39% <0.00%> (+0.07%) ⬆️
unittests 73.65% <0.00%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rg/apache/pulsar/broker/service/AbstractTopic.java 87.91% <0.00%> (-0.08%) ⬇️

... and 628 files with indirect coverage changes

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the great improvements, @rdhabalia

@lhotari lhotari closed this Oct 10, 2024
@lhotari lhotari reopened this Oct 10, 2024
@lhotari
Copy link
Member

lhotari commented Oct 10, 2024

Closed and reopened to get Pulsar CI to run with fix PR #23431

@rdhabalia rdhabalia merged commit bc3e7f6 into apache:master Oct 10, 2024
92 of 97 checks passed
@rdhabalia rdhabalia deleted the schema_rec branch October 10, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants