[improve][client] Increase default Java client connectionMaxIdleSeconds to 60 seconds #23430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds to 60 seconds - the reason is that the default for autoUpdatePartitionsInterval is 60 seconds and if idle timeout is shorter, it causes connections to close and open unnecessarily
poorbarcode
approved these changes
Oct 10, 2024
shibd
approved these changes
Oct 10, 2024
nodece
approved these changes
Oct 10, 2024
dao-jun
approved these changes
Oct 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23430 +/- ##
============================================
+ Coverage 73.57% 74.31% +0.73%
- Complexity 32624 34340 +1716
============================================
Files 1877 1949 +72
Lines 139502 146867 +7365
Branches 15299 16168 +869
============================================
+ Hits 102638 109141 +6503
- Misses 28908 29291 +383
- Partials 7956 8435 +479
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 15, 2024
…ds to 60 seconds (apache#23430) (cherry picked from commit 8600316) (cherry picked from commit 15e76a8)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 16, 2024
…ds to 60 seconds (apache#23430) (cherry picked from commit 8600316) (cherry picked from commit 15e76a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The setting was decreased from 180 seconds to 25 seconds in #22541.
The default setting of 25 seconds is causing connection disconnects and connects when they aren't expected.
The reason is that the default for autoUpdatePartitionsInterval is 60 seconds and if idle timeout is shorter, it causes connections to close and open unnecessarily each time the scheduled task runs.
Modifications
Increase connectionMaxIdleSeconds to 60 seconds
Documentation
docdoc-requireddoc-not-neededdoc-complete