Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-389: Add Producer config compressMinMsgBodySize to improve compression performance #23526

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

liangyepianzhou
Copy link
Contributor

Motivation

The motivation of this PIP is to provide a way to improve the compression performance by skipping the compression of small messages.
We want to add a new configuration compressMinMsgBodySize to the producer configuration.
This configuration will allow the user to set the minimum size of the message body that will be compressed.
If the message body size is less than the compressMinMsgBodySize, the message will not be compressed.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added PIP doc-required Your PR changes impact docs and you will update later. labels Oct 29, 2024
@lhotari
Copy link
Member

lhotari commented Oct 30, 2024

Please add the PIP number to the PR title as we usually do.

@liangyepianzhou liangyepianzhou changed the title [improve][pip] Add Producer config compressMinMsgBodySize to improve compression performance [improve][pip]PIP-389 Add Producer config compressMinMsgBodySize to improve compression performance Oct 30, 2024
@lhotari lhotari changed the title [improve][pip]PIP-389 Add Producer config compressMinMsgBodySize to improve compression performance [improve][pip]PIP-389: Add Producer config compressMinMsgBodySize to improve compression performance Nov 27, 2024
@lhotari
Copy link
Member

lhotari commented Nov 27, 2024

@liangyepianzhou Please go ahead and close the vote thread. We don't need 3 binding votes for PIPs anymore, that was clarified in #23387.

Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari lhotari changed the title [improve][pip]PIP-389: Add Producer config compressMinMsgBodySize to improve compression performance [improve][pip] PIP-389: Add Producer config compressMinMsgBodySize to improve compression performance Nov 27, 2024
@liangyepianzhou liangyepianzhou merged commit c50fa56 into master Nov 28, 2024
24 checks passed
@liangyepianzhou liangyepianzhou deleted the pip/pip-389 branch November 28, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required Your PR changes impact docs and you will update later. PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants