Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][pip] PIP-392: Enable consistent hashing to select active consumer in partitioned topic for failover subscription #23583

Merged
merged 5 commits into from
Nov 20, 2024
Merged

[improve][pip] PIP-392: Enable consistent hashing to select active consumer in partitioned topic for failover subscription #23583

merged 5 commits into from
Nov 20, 2024

Conversation

shibd
Copy link
Member

@shibd shibd commented Nov 11, 2024 •
edited
Loading

@shibd
[improve][pip] PIP-392: Add configuration to enable consistent hashin…
ee01767 
…g to select active consumer for partitioned topic
@github-actions GitHub Actions
Copy link

@shibd Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@shibd shibd self-assigned this Nov 11, 2024
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 11, 2024
@shibd shibd mentioned this pull request Nov 11, 2024
Merged
4 tasks
lhotari
lhotari reviewed Nov 11, 2024
View reviewed changes
pip/pip-392.md Outdated Show resolved Hide resolved
lhotari
lhotari reviewed Nov 11, 2024
View reviewed changes
pip/pip-392.md Outdated Show resolved Hide resolved
@shibd shibd requested a review from lhotari November 11, 2024 10:08
@shibd shibd changed the title [improve][pip] PIP-392: Add configuration to enable consistent hashing to select active consumer for partitioned topic [improve][pip] PIP-392: Enable consistent hashing to select active consumer in partitioned topic for failover subscription Nov 11, 2024
@shibd shibd requested a review from lhotari November 12, 2024 14:15
Technoboy-
Technoboy- approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibd
Copy link
Member Author

shibd commented Nov 20, 2024

Vote passed, I will merge this PIP.

@shibd shibd merged commit 5338dc9 into apache:master Nov 20, 2024
22 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
@shibd @hanmz
[improve][pip] PIP-392: Enable consistent hashing to select active co…
0a539bf 
…nsumer in partitioned topic for failover subscription (apache#23583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhotari lhotari lhotari left review comments

@grssam grssam grssam left review comments

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui Awaiting requested review from codelipenghui

@poorbarcode poorbarcode Awaiting requested review from poorbarcode

Assignees

@shibd shibd

Labels
doc-not-needed Your PR changes do not impact docs PIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shibd @lhotari @grssam @Technoboy-