-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][admin] Listen partitioned topic creation event #23680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
dao-jun
approved these changes
Dec 4, 2024
liudezhi2098
approved these changes
Dec 5, 2024
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23680 +/- ##
============================================
+ Coverage 73.57% 74.43% +0.85%
- Complexity 32624 35089 +2465
============================================
Files 1877 1945 +68
Lines 139502 147448 +7946
Branches 15299 16269 +970
============================================
+ Hits 102638 109750 +7112
- Misses 28908 29231 +323
- Partials 7956 8467 +511
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0a2ffe4)
lhotari
pushed a commit
that referenced
this pull request
Dec 11, 2024
Signed-off-by: Zixuan Liu <nodeces@gmail.com> (cherry picked from commit 0a2ffe4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/branch-3.0
cherry-picked/branch-4.0
doc-not-needed
Your PR changes do not impact docs
release/3.0.9
release/4.0.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I have a broker interceptor, which will add a topic event listener to listen the topic creation in the
org.apache.pulsar.broker.intercept.BrokerInterceptor#initialize
. However, the partitioned topic creation event can not be recorded(bin/pulsar-admin topics create-partitioned-topic -p 3 test-topic-event
).The non-partitioned topic works fine.
Modifications
topicEventsDispatcher
with theTopicEvent.CREATE
andEventStage.BEFORE
before creating the persistent/non-persistent partitioned topic.topicEventsDispatcher
with theTopicEvent.CREATE
andEventStage.SUCCESS/FAILURE
after the persistent/non-persistent partitioned topic is created.Documentation
doc
doc-required
doc-not-needed
doc-complete