kerberos: authentication between client and broker #3821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eolivelli Thanks for the comments in #3658. This is the second version. |
|
@jiazhai I will take a look |
eolivelli
reviewed
Mar 14, 2019
| ### --- SASL Authentication Provider --- ### | ||
|
|
||
| # Whether Use SASL Authentication or not. | ||
| # TODO: used to bypass web resource check. will remove it after implementation the support. |
There was a problem hiding this comment.
Thanks @eolivelli , yes, there is a planed work.
current step is for client <-> broker. will add the web-resource/http support in the TODO issue.
There was a problem hiding this comment.
by this parameter we could bypass the web-resource/http checking temporary.
eolivelli
approved these changes
Mar 18, 2019
sijie
approved these changes
Mar 19, 2019
sijie
added
the
type/feature
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3652
Motivation
Currently both Zookeeper and BookKeeper could be secured by using Kerberos, It would be good to support Kerberos in Pulsar Broker and Client.
This is the sub-task for issue in #3491 to support Kerberos in Pulsar Broker and Client.
Will add proxy and web resource support in following prs.
The Kerberos authentication is similar to that in Zookeeper and BookKeeper, which leverage SASL and GSSAPI, so reused some of the code there.
PR #3658 is the first version of PR before #3677 .
Changes
provide both client and broker side support for authentication api;
add unit test.