-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Functions] Support skywalking for performance monitoring #6036
Conversation
add skywalking options
add SkywalkingConfig class in FunctionConfig.java
add SkywalkingConfig.java
add Skywalking config in Function.proto
set skywalking properties in runtime cmd
add Skywalking config convert
add SkywalkingConfigUtils.java
import Skywalking config
@xuesong172500 thank you for submitting the pull request for adding Skywalking support for Pulsar Functions! It is a great initiative and I believe that it will take Pulsar Functions into the next level. However, the implementation seems to be tightly coupled with skywalking. I think we need to step back a bit and think about a general framework for adding extensions and plugins to functions. Otherwise, it becomes unmanageable. /cc @wolfstudy @jerrypeng @srkukarni for inputs on this feature. |
forgot to /cc @codelipenghui as he did the Skywalking and Pulsar integration before. |
Totally agree with you. |
@sijie I agree. Lets create a generic interface for something like this |
Closed as stale, conflict, and no consensus. |
Modifications
Describe the modifications you've done.
Verifying this change
update:
Function.proto
RuntimeUtils.java
FunctionConfig.java
CmdFunctions.java
FunctionConfigUtils.java
add:
SkywalkingConfig.java
SkywalkingConfigUtils.java
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Pulsar function supports skywalking
Usage:
bin/pulsar-admin functions create
--jar examples/filter.jar
--classname com.newland.filter.FilterFunction
--tenant public
--namespace default
--name filtertest3
--inputs persistent://public/default/filter-input
--output persistent://public/default/rr-input
--skywalking-agent-conf-path /opt/app/pulsar-2.4.1/skywalking/agent/config/agent.config
--skywalking-agent-jar-path /opt/app/pulsar-2.4.1/skywalking/agent/skywalking-agent.jar
--skywalking-backend-service 127.0.0.1:41800
skywalking-agent-conf-path、skywalking-backend-service,It can exist at the same time or fill in only one。