DISPATCH-1959 Update PatternFly packages for the 1.16.0 release #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this issue was missed in DISPATCH-1725
When this is not done correctly, the test error is
```
qpid-dispatch/qpid-dispatch/console/react/node_modules/react-dom/cjs/react-dom.development.js:3905
var evt = document.createEvent('Event');
^
TypeError: Cannot read property 'createEvent' of null
```
Codecov Report
@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 82.32% 82.26% -0.06%
==========================================
Files 111 111
Lines 27537 27537
==========================================
- Hits 22669 22654 -15
- Misses 4868 4883 +15
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still missing a resolution for facebook/create-react-app#10762, I guess that can come later, there is still time before release, and it's only a dev dependency.