Remove unused dependencies #360
Conversation
|
@mneethiraj I have found these using Would you like to grant me some access so CI could be executed for my PRs so I could see if my changes are working? |
|
FYI @ksobolew |
kokosing
changed the title
kokosing
force-pushed
the
origin/master/013_unused_deps
branch
from
4479b32
to
c650d89
Compare
|
I am not sure if it is the correct direction. I am not sure if I can trust |
|
@mneethiraj do you think this is something I should invest my time in? |
|
@kokosing - removal of unused dependencies will be of huge help; thank you for getting started on this. Can you please rebase this PR, so that I can trigger CI? BTW, I recently started contributing to Trino; really liked Trino enforces several things during build time - like unused dependencies, duplicate classes, conflicting versions of dependencies, strict ordering of dependencies (in pom.xml). It will be awesome to get these in Ranger as well. Given your background in Trino, will you be able to help with these? |
kokosing
force-pushed
the
origin/master/013_unused_deps
branch
from
e8bf9ef
to
f25a888
Compare
|
I have rebased the PR. The way how it is done in Trino is an effect of huge effort over many years by multiple people. I am afraid I might not be able to migrate the entire Ranger project. The way it is done is via usage of https://github.com/airlift/airbase. It is easy to start a new project that is based on that, with existing project huge effort. However the biggest challenge I have with it is how to maek sure that changes I would be doing are safe to merge. It is easy to have compilation passing, but get errors on runtime. @mneethiraj do you believe that Ranger have good enough test coverage in CI that we move forward with it? |
Remove unused dependencies