[ISSUE #88] select slave broker when master broker is unavailable. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifplusor
changed the title
ifplusor
force-pushed
the
fixed-select-slave
branch
4 times, most recently
from
6264ac7 to
6e958e2
Compare
jonnxu
reviewed
Mar 25, 2019
src/MQClientFactory.cpp
Outdated
| found = true; | ||
| } else if (!onlyThisBroker) { // not only from master | ||
| iter = brokerMap.begin(); | ||
| brokerAddr = iter->second; |
There was a problem hiding this comment.
i think here need add if(iter != brokerMap.end())
There was a problem hiding this comment.
i have changed it.
merged from MQClientInstance#findBrokerAddrByTopic, BrokerData#selectBrokerAddr and MQClientInstance#findBrokerAddressInSubscribe in Java client.
ifplusor
force-pushed
the
fixed-select-slave
branch
from
6e958e2 to
d379ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
ISSUE #88
fixed the bug, can't select slave broker when findConsumerIds. this cause can't consume slave.
Brief changelog
select broker random first, and use the master. if the master is unavailable, select a slave of it.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.