Support muti-thread compile in build.sh #127
Merged
+6
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShannonDing
changed the title
jovany-wang
suggested changes
May 17, 2019
build.sh
Outdated
| @@ -176,7 +176,7 @@ BuildLibevent() | |||
| if [ $? -ne 0 ];then | |||
| exit 1 | |||
| fi | |||
| make | |||
| make -j | |||
There was a problem hiding this comment.
It's better to use make -j ${NUM_CORE},
and let get NUM_CORE automatically.
jonnxu
reviewed
Jul 24, 2019
build.sh
Outdated
| @@ -214,7 +214,7 @@ BuildJsonCPP() | |||
| if [ $? -ne 0 ];then | |||
| exit 1 | |||
| fi | |||
| make | |||
| make -j | |||
There was a problem hiding this comment.
please Uniform amendment to make -j4 ？
-j [jobs], --jobs[=jobs]
Specifies the number of jobs (commands) to run simultaneously. If there is more than one -j option, the last one is effective.If the -j option is given without an argument, make will not limit the number of jobs that can run simultaneously.
jovany-wang
suggested changes
Jul 29, 2019
build.sh
Outdated
| @@ -176,7 +176,7 @@ BuildLibevent() | |||
| if [ $? -ne 0 ];then | |||
| exit 1 | |||
| fi | |||
| make | |||
| make -j4 | |||
There was a problem hiding this comment.
Let's define a variable to set the num of cpus like:
NUM_CPUS=4
...
make -j $NUM_CPUS
So that if some one's machine has 16 cores, he/she can specify this simply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
to speed up compilation
Brief changelog
Added the parameter
-jfor make inbuild.shVerifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.