[ISSUE #142] save string::find result into a string::size_type variable. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
close #142 |
This was referenced May 15, 2019
Closed
hugoasdf
pushed a commit
to hugoasdf/rocketmq-client-cpp
that referenced
this pull request
Jun 30, 2019
…variable. declare correct string::size_type by auto. (apache#143)
hugoasdf
added a commit
to hugoasdf/rocketmq-client-cpp
that referenced
this pull request
Jun 30, 2019
* [ISSUE apache#142] save string::find result into a string::size_type variable. declare correct string::size_type by auto. (apache#143) * batch issue * Update: update network interface. (apache#60) * update network interface. - feature: use only one event loop for all TcpTransport. - update: network components. * remove boost mutex, timed_mutex and condition_variable in TcpRemotingClient, TcpTransport and ReponseFunture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
save string::find result into a string::size_type variable to compare with string::nops
Brief changelog
replace unsigned int by auto to save string::size_type.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.