Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove removeDropedPullRequestOpaque and deleteOpaqueForDropPullRequest. #157

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

ifplusor
Copy link
Contributor

What is the purpose of the change

clean up.

Brief changelog

remove removeDropedPullRequestOpaque and deleteOpaqueForDropPullRequest.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

Copy link
Contributor

@jonnxu jonnxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i suggest reserve this two logs

src/MQClientFactory.cpp Show resolved Hide resolved
src/MQClientAPIImpl.cpp Show resolved Hide resolved
@jonnxu
Copy link
Contributor

jonnxu commented Jul 8, 2019

LMGT

@jonnxu jonnxu added the remove useless code remove useless code label Jul 8, 2019
@jonnxu jonnxu merged commit 8b6cb07 into apache:master Jul 8, 2019
@ifplusor ifplusor deleted the cleanup branch July 8, 2019 22:02
@ShannonDing ShannonDing added this to the 1.2.3 milestone Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remove useless code remove useless code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants