Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify deploy shell to package license and notice file #179

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Modify deploy shell to package license and notice file #179

merged 1 commit into from
Aug 18, 2019

Conversation

ShannonDing
Copy link
Member

@ShannonDing ShannonDing commented Aug 16, 2019

What is the purpose of the change

#177
Modify deploy shell to package license and notice file

Brief changelog

Move deploy.sh to distribution dir
Modify deploy shell to package license and notice file

Verifying this change

sh deploy.sh
check the package

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@jonnxu
Copy link
Contributor

jonnxu commented Aug 18, 2019

LGTM

@jonnxu jonnxu merged commit 32fb1c8 into apache:master Aug 18, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 19, 2019
@ShannonDing ShannonDing added this to the 1.2.3 milestone Aug 19, 2019
@ShannonDing ShannonDing deleted the package branch September 24, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants