Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): update notice and open statistic label #220

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

[ISSUE #219 ]
fix(doc): update notice and open statistic label

Brief changelog

fix(doc): update notice and open statistic label

Verifying this change

fix(doc): update notice and open statistic label

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 8, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #220 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files         171      171           
  Lines       10243    10243           
=======================================
  Hits         4664     4664           
  Misses       5579     5579

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a7f8b2...514ec81. Read the comment docs.

@ShannonDing ShannonDing merged commit 2faaa1f into apache:master Jan 8, 2020
@ShannonDing ShannonDing deleted the notice branch January 10, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants