Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): delete string print in header decode and open test cases. #223

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

[ISSUE #111 ]fix(protocol): delete string print in header decode and open test cases.

Brief changelog

  1. delete string print in header decode
  2. add test cases for command decode

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing added the bug Something isn't working label Jan 10, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 10, 2020
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #223 into master will increase coverage by 3.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
+ Coverage   47.82%   51.01%   +3.19%     
==========================================
  Files         173      173              
  Lines       10441    10701     +260     
==========================================
+ Hits         4993     5459     +466     
+ Misses       5448     5242     -206
Impacted Files Coverage Δ
test/src/producer/StringIdMakerTest.cpp 100% <ø> (ø)
test/src/protocol/ConsumerRunningInfoTest.cpp 100% <100%> (ø) ⬆️
src/protocol/CommandHeader.cpp 81.4% <100%> (+34.5%) ⬆️
test/src/protocol/CommandHeaderTest.cpp 100% <100%> (ø) ⬆️
test/src/protocol/LockBatchBodyTest.cpp 100% <100%> (ø) ⬆️
src/protocol/MessageQueue.cpp 86.53% <0%> (+1.92%) ⬆️
src/consumer/SubscriptionData.cpp 43.33% <0%> (+8.33%) ⬆️
src/protocol/CommandHeader.h 70.76% <0%> (+21.56%) ⬆️
src/protocol/LockBatchBody.h 100% <0%> (+33.33%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b3b35...2baa1d0. Read the comment docs.

@ShannonDing ShannonDing merged commit 54a3878 into apache:master Jan 10, 2020
@ShannonDing ShannonDing deleted the decode branch January 13, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants