Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): fix variable in build script #237

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

gitoso
Copy link
Contributor

@gitoso gitoso commented Feb 10, 2020

What is the purpose of the change

The line unzip -o ${fname_libevent} >unziplibevent.txt 2>& creates the file unziplibevent.txt in the directory. So when setting the directory name with libevent_dir=$(ls | grep libevent | grep .*[^zip]$) the variable will have the name of two files and cd ${libevent_dir} will prompt cd: Too many arguments.

Brief changelog

Just adding the .txt extension to the exclusion list during the grep command is enough to solve the problem. In the end we have libevent_dir=$(ls | grep libevent | grep .*[^zip^txt]$).

@ShannonDing ShannonDing added this to the 1.2.5 milestone Feb 11, 2020
@ShannonDing ShannonDing added the bug Something isn't working label Feb 11, 2020
@ShannonDing ShannonDing merged commit e594218 into apache:master Feb 11, 2020
@ShannonDing
Copy link
Member

hello, @gitoso , welcome to apache rocketmq community, the GSoC 2020 will be starting soon, could you please send an email to me and I will send you some information about it if you are interested in it?

@gitoso
Copy link
Contributor Author

gitoso commented Feb 19, 2020

hello, @gitoso , welcome to apache rocketmq community, the GSoC 2020 will be starting soon, could you please send an email to me and I will send you some information about it if you are interested in it?

Thank you, I sent a message to the email in your github profile ^^

@vongosling
Copy link
Member

@gitoso here are some preliminary proposal(apache/rocketmq-externals#512). if you are interested, we would like to help you to complete these in the nearing GSoC 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants