Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(build): use dynamic cpu cores to compile code. #265

Merged
merged 2 commits into from
Feb 28, 2020

Conversation

WoodsCumming
Copy link
Contributor

What is the purpose of the change

Modify the default number of threads used for compilation on Linux and MAC platforms to be the number of CPU logical cores, rather than hardcode.

Brief changelog

Modify the default number of threads used for compilation on Linux and MAC platforms to be the number of CPU logical cores, rather than hardcode.

Verifying this change

Verified. Want a code review.

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

yizhe.wcm added 2 commits February 27, 2020 20:11
…umber of CPU logical cores instead of hardcode.
…d MAC platforms to be the number of CPU logical cores, rather than hardcode.
@ShannonDing ShannonDing added the enhancement New feature or request label Feb 28, 2020
@ShannonDing ShannonDing added this to the 2.0.1 milestone Feb 28, 2020
@ShannonDing ShannonDing added the refactor refactor functions label Feb 28, 2020
@ShannonDing ShannonDing changed the title Modify the default number of threads used for compilation on Linux and MAC platforms to be the number of CPU logical cores, rather than hardcode. refactor(build): use dynamic cpu cores to compile code. Feb 28, 2020
@ShannonDing ShannonDing merged commit a90b074 into apache:master Feb 28, 2020
@WoodsCumming WoodsCumming deleted the default_cpu_cores_for_compile branch February 29, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor refactor functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants