Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #86] fixed GetMessageStoreTimestamp not return StoreTimestamp #90

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

ifplusor
Copy link
Contributor

@ifplusor ifplusor commented Jan 30, 2019

What is the purpose of the change

fixed the bug #86
GetMessageStoreTimestamp not return StoreTimestamp

Brief changelog

-    return ((MQMessageExt *) msg)->getBornTimestamp();
+    return ((MQMessageExt *) msg)->getStoreTimestamp();

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ShannonDing ShannonDing merged commit fed75d8 into apache:master Jan 31, 2019
@ifplusor ifplusor deleted the fixed-86 branch February 15, 2019 11:39
@ShannonDing ShannonDing added the bug Something isn't working label Mar 14, 2019
@ShannonDing ShannonDing added this to the 1.2.2 milestone Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants