Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed MQDecoder::createMessageId and MQDecoder::decodeMessageId. #92

Merged
merged 1 commit into from
Feb 15, 2019

Conversation

ifplusor
Copy link
Contributor

@ifplusor ifplusor commented Jan 31, 2019

What is the purpose of the change

  • make MQDecoder::createMessageId same as MessageDecoder.createMessageId in Java;
  • fixed MQDecoder::decodeMessageId decode offset error

Brief changelog

  • change MQDecoder::createMessageId
  • fixed UtilAll::hexstr2ull and MQDecoder::decodeMessageId

Verifying this change

code [ip:127.0.0.1, port:10091, offset: 1024] to '7F0000010000276B0000000000000400'

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

- make MQDecoder::createMessageId same as MessageDecoder.createMessageId in Java;
- fixed MQDecoder::decodeMessageId decode offset error
@ifplusor
Copy link
Contributor Author

resolved #81

@ShannonDing ShannonDing added this to the 1.2.2 milestone Feb 12, 2019
@ShannonDing ShannonDing merged commit d0b0be0 into apache:master Feb 15, 2019
@ifplusor ifplusor deleted the fixed-MQDecoder branch February 15, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants