use openssl provider instead of jdk provider to improve performance #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 45.01% 45.01%
=======================================
Files 107 107
Lines 4567 4567
Branches 676 677 +1
=======================================
Hits 2056 2056
Misses 2157 2157
Partials 354 354
Help us with your feedback. Take ten seconds to tell us how you rate us. |
DongyuanPan
reviewed
Jul 21, 2022
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
Outdated
Show resolved
Hide resolved
ShannonDing
reviewed
Jul 31, 2022
ShannonDing
requested changes
Jul 31, 2022
mqtt-cs/src/main/java/org/apache/rocketmq/mqtt/cs/protocol/ssl/SslFactory.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to resolve @pingww 's review in PR-115 Support tls tcp server. Switch ssl provider to openssl, performance will be better.
link #51