Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #135] Delete unused data members, and optimizing abstract interfaces #136

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

DongyuanPan
Copy link
Contributor

#135 Delete unused data members, and optimizing abstract interfaces

@codecov-commenter
Copy link

Codecov Report

Merging #136 (dee34c9) into develop (c8f6b55) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #136      +/-   ##
===========================================
+ Coverage    41.95%   41.97%   +0.01%     
===========================================
  Files          118      118              
  Lines         4900     4898       -2     
  Branches       713      713              
===========================================
  Hits          2056     2056              
+ Misses        2490     2488       -2     
  Partials       354      354              
Impacted Files Coverage Δ
...ache/rocketmq/mqtt/meta/raft/MqttStateMachine.java 0.00% <ø> (ø)
...qtt/meta/raft/processor/CounterStateProcessor.java 0.00% <0.00%> (ø)
...ketmq/mqtt/meta/raft/processor/StateProcessor.java 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pingww pingww merged commit 9b1f8d1 into apache:develop Aug 11, 2022
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 11, 2022
@ShannonDing ShannonDing changed the title Delete unused data members, and optimizing abstract interfaces [ISSUE #135] Delete unused data members, and optimizing abstract interfaces Aug 11, 2022
@ShannonDing ShannonDing linked an issue Aug 11, 2022 that may be closed by this pull request
Copy link
Member

@ShannonDing ShannonDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete unused data members
4 participants