Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The comment description of the default value in the keepalivetime field of the RocketMQTransactionListener annotation is incorrect #439

Closed
yanghao888 opened this issue Mar 18, 2022 · 2 comments
Closed

The comment description of the default value in the keepalivetime field of the RocketMQTransactionListener annotation is incorrect #439

yanghao888 opened this issue Mar 18, 2022 · 2 comments

Comments

@yanghao888
Copy link
Contributor

rocketmq-spring-boot-starter版本: 2.2.1和2.2.2-SNAPSHOT都存在这个问题

注解中行末注释描述是60ms
image

实际换算应该是60s
image

应该是注释描述有误，或者考虑把单位也放到注解中配置呢？
@RongtongJin
Copy link
Contributor

Could you submit a pull request to fix the issue?

@RongtongJin RongtongJin changed the title RocketMQTransactionListener注解的keepAliveTime字段的对于默认值的注释描述好像有误 The comment description of the default value in the keepalivetime field of the RocketMQTransactionListener annotation is incorrect Mar 24, 2022
RongtongJin pushed a commit that referenced this issue Mar 25, 2022
@yanghao888
[ISSUE #439] Fix the wrong comment description of the default value i…
acd0ee9 
…n the keepalivetime field of the RocketMQTransactionListener annotation.
@RongtongJin
Copy link
Contributor

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RongtongJin @yanghao888