Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RIP-26] [Feature] Both CQ and BCQ need to be supported in DefaultMessageStore. #3708

Closed
Erik1288 opened this issue Jan 5, 2022 · 3 comments
Closed

[RIP-26] [Feature] Both CQ and BCQ need to be supported in DefaultMessageStore. #3708

Erik1288 opened this issue Jan 5, 2022 · 3 comments
Labels
module/store type/new feature

Comments

@Erik1288
Copy link
Contributor

Erik1288 commented Jan 5, 2022

The issue tracker is ONLY used for bug report(feature request need to follow RIP process). Keep in mind, please check whether there is an existing same report before your raise a new one.

Alternately (especially if your communication is not a bug report), you can send mail to our mailing lists. We welcome any friendly suggestions, bug fixes, collaboration and other improvements.

Please ensure that your bug report is clear and that it is complete. Otherwise, we may be unable to understand it or to reproduce it, either of which would prevent us from fixing the bug. We strongly recommend the report(bug report or feature request) could include some hints as the following:

FEATURE REQUEST

  1. Please describe the feature you are requesting.
    Both CQ and BCQ need to be supported in DefaultMessageStore.

  2. Provide any additional detail on your proposed use case for this feature.

  • ). Remove StreamMessageStore
  • ). Make DefaultMessageStore support both BCQ and CQ.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  2. If there are some sub-tasks using -[] for each subtask and create a corresponding issue to map to the sub task:

  • [Refactor CQ and BCQ loading process]: unify loading process.
  • [add CorrectLogicOffsetService): add CorrectLogicOffsetService to periodically correct min logic offset.
@Git-Yang
Copy link
Member

Git-Yang commented Jan 5, 2022

Link #3704

@Git-Yang Git-Yang mentioned this issue Jan 5, 2022
Closed
6 tasks
@Erik1288 Erik1288 mentioned this issue Jan 5, 2022
Merged
6 tasks
@vongosling
Copy link
Member

@Git-Yang You could link it in the pr. Actually, pr and issue are mutually linked if you notice the GitHub toolbar on the right side.

RongtongJin pushed a commit that referenced this issue Jan 6, 2022
@Erik1288
[ISSUE #3708] Both CQ and BCQ need to be supported in DefaultMessageS…
e923a7e 
…tore. (#3712)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.
RongtongJin pushed a commit that referenced this issue Jan 6, 2022
@Erik1288
[ISSUE #3708] Refactor CQ and BCQ loading process and Fix some unit-t…
0d62194 
…ests issue. (#3713)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* Part of ISSUE #3708. Refactor CQ and BCQ loading process.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.
RongtongJin pushed a commit that referenced this issue Jan 10, 2022
@Erik1288
[ISSUE #3708] add CorrectLogicOffsetService to periodically correct m…
7be401e 
…in logic offset (#3722)

* [ISSUE #3708] add CorrectLogicOffsetService to periodically correct min logic offset; refactor QueueOffsetAssigner.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio to get around configuration protection in unit-test.

* Fix check style.
@RongtongJin
Copy link
Contributor

All Merged

RongtongJin pushed a commit that referenced this issue Feb 8, 2022
@Erik1288 @RongtongJin
[ISSUE #3708] Both CQ and BCQ need to be supported in DefaultMessageS…
e8cf133 
…tore. (#3712)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.
RongtongJin pushed a commit that referenced this issue Feb 8, 2022
@Erik1288 @RongtongJin
[ISSUE #3708] Refactor CQ and BCQ loading process and Fix some unit-t…
6172ad3 
…ests issue. (#3713)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* Part of ISSUE #3708. Refactor CQ and BCQ loading process.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.
RongtongJin pushed a commit that referenced this issue Feb 8, 2022
@Erik1288 @RongtongJin
[ISSUE #3708] add CorrectLogicOffsetService to periodically correct m…
78a3ed7 
…in logic offset (#3722)

* [ISSUE #3708] add CorrectLogicOffsetService to periodically correct min logic offset; refactor QueueOffsetAssigner.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio to get around configuration protection in unit-test.

* Fix check style.
cserwen pushed a commit to cserwen/rocketmq that referenced this issue Jun 18, 2024
@Erik1288
[ISSUE apache#3708] Both CQ and BCQ need to be supported in DefaultMe…
a150e77 
…ssageStore. (apache#3712)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.
cserwen pushed a commit to cserwen/rocketmq that referenced this issue Jun 18, 2024
@Erik1288
[ISSUE apache#3708] Refactor CQ and BCQ loading process and Fix some …
464632a 
…unit-tests issue. (apache#3713)

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* [RIP-26] Both CQ and BCQ will be supported in DefaultMessageStore.

* Part of ISSUE apache#3708. Refactor CQ and BCQ loading process.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio for ut.

* Optimize batch message unit-test.
cserwen pushed a commit to cserwen/rocketmq that referenced this issue Jun 18, 2024
@Erik1288
[ISSUE apache#3708] add CorrectLogicOffsetService to periodically cor…
46382d9 
…rect min logic offset (apache#3722)

* [ISSUE apache#3708] add CorrectLogicOffsetService to periodically correct min logic offset; refactor QueueOffsetAssigner.

* Mock getDiskSpaceWarningLevelRatio and getDiskSpaceCleanForciblyRatio to get around configuration protection in unit-test.

* Fix check style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/store type/new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vongosling @Erik1288 @RongtongJin @Git-Yang