[ISSUE #3585] [Part J] Use MappedByteBuffer instead of FileChannel to … #3657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…write consume queue and slave commitlog. This commit improve reput performance and speed up consume qps greatly. In our test, produce about 200,000 tps. 72 queue consume qps: from about 70,000 to 200,000 600 queue consume qps: from about 70,000 to 110,000
Codecov Report
@@ Coverage Diff @@
## develop #3657 +/- ##
=============================================
- Coverage 49.69% 49.67% -0.02%
+ Complexity 4725 4723 -2
=============================================
Files 555 555
Lines 36798 36800 +2
Branches 4853 4853
=============================================
- Hits 18286 18281 -5
- Misses 16214 16220 +6
- Partials 2298 2299 +1
Continue to review full report at Codecov.
|
|
before:
after:
|
caigy
approved these changes
Dec 16, 2021
panzhi33
approved these changes
Dec 17, 2021
yuz10
approved these changes
Dec 21, 2021
Git-Yang
approved these changes
Dec 22, 2021
duhenglucky
approved these changes
Dec 26, 2021
RongtongJin
approved these changes
Dec 27, 2021
francisoliverlee
changed the title
devfat
pushed a commit
to devfat/rocketmq
that referenced
this pull request
Mar 3, 2022
…write consume queue and slave commitlog. (apache#3657) This commit improve reput performance and speed up consume qps greatly. In our test, produce about 200,000 tps. 72 queue consume qps: from about 70,000 to 200,000 600 queue consume qps: from about 70,000 to 110,000
GenerousMan
pushed a commit
to GenerousMan/rocketmq
that referenced
this pull request
Aug 12, 2022
…write consume queue and slave commitlog. (apache#3657) This commit improve reput performance and speed up consume qps greatly. In our test, produce about 200,000 tps. 72 queue consume qps: from about 70,000 to 200,000 600 queue consume qps: from about 70,000 to 110,000
|
Actually, mmap is better than fileChannel in small size message case. In large scale size message, fileChannel is more better. |
|
As another effect, we found after upgrade to 4.9.4, mmap avoid many swap usage rather than older version with fileChannel. |
3 tasks
carlvine500
pushed a commit
to carlvine500/rocketmq-apache
that referenced
this pull request
Sep 10, 2024
…write consume queue and slave commitlog. (apache#3657) This commit improve reput performance and speed up consume qps greatly. In our test, produce about 200,000 tps. 72 queue consume qps: from about 70,000 to 200,000 600 queue consume qps: from about 70,000 to 110,000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure set the target branch to
developWhat is the purpose of the change
speed up reput performance (relative to consumer tps) .
Brief changelog
Use MappedByteBuffer instead of FileChannel to write consume queue and slave commitlog.
Verifying this change
This commit improve reput performance and speed up consume qps greatly. In our test, produce about 200,000 tps.
72 queue consume qps: from about 70,000 to 200,000
600 queue consume qps: from about 70,000 to 110,000
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.