Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6141] validate group when auto create subscription group #6142

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

yuz10
Copy link
Member

@yuz10 yuz10 commented Feb 21, 2023

Make sure set the target branch to develop

What is the purpose of the change

fix #6141

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

Codecov Report

Merging #6142 (e9c359b) into develop (4cc3311) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             develop    #6142   +/-   ##
==========================================
  Coverage      43.22%   43.23%           
- Complexity      8852     8854    +2     
==========================================
  Files           1094     1094           
  Lines          77146    77148    +2     
  Branches       10060    10061    +1     
==========================================
+ Hits           33350    33357    +7     
- Misses         39623    39625    +2     
+ Partials        4173     4166    -7     
Impacted Files Coverage Δ
.../broker/subscription/SubscriptionGroupManager.java 65.54% <0.00%> (-0.90%) ⬇️
...q/namesrv/routeinfo/BrokerHousekeepingService.java 70.00% <0.00%> (-10.00%) ⬇️
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 82.21% <0.00%> (-2.41%) ⬇️
...ache/rocketmq/proxy/common/ReceiptHandleGroup.java 65.30% <0.00%> (-2.05%) ⬇️
...he/rocketmq/client/impl/consumer/ProcessQueue.java 59.91% <0.00%> (-0.89%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 78.22% <0.00%> (-0.54%) ⬇️
...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java 63.25% <0.00%> (-0.33%) ⬇️
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.22% <0.00%> (-0.25%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
.../org/apache/rocketmq/store/ha/DefaultHAClient.java 61.53% <0.00%> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuz10 yuz10 merged commit eda205b into apache:develop Feb 21, 2023
@yuz10 yuz10 deleted the develop6 branch February 21, 2023 14:12
mxsm pushed a commit to mxsm/rocketmq that referenced this pull request Feb 23, 2023
apache#6142)

* validate group when auto create subscription group

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate group when auto create subscription group
3 participants