Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #6358]Add chinese docs about persistent-unique-broker-id #6359

Conversation

TheR1sing3un
Copy link
Member

Make sure set the target branch to develop

What is the purpose of the change

  1. add chinese docs about persistent-unique-broker-id
    closes Add chinese docs about persistent-unique-broker-id #6358

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

1. add chinese docs about persistent-unique-broker-id
1. optimize style in docs: persistent-unique-broker-id.md
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2023

Codecov Report

Merging #6359 (2a66d05) into develop (4a4626d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #6359      +/-   ##
=============================================
- Coverage      43.00%   42.99%   -0.02%     
+ Complexity      8897     8891       -6     
=============================================
  Files           1103     1103              
  Lines          77839    77839              
  Branches       10134    10134              
=============================================
- Hits           33472    33463       -9     
- Misses         40176    40181       +5     
- Partials        4191     4195       +4     

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheR1sing3un 文档的结构标题排版需要在处理一下,以及后面的这个图片需要重新整理一下。看起来更加正式一点

1. remove test in docs: persistent-unique-broker-id.md
@TheR1sing3un TheR1sing3un requested review from RongtongJin and mxsm and removed request for RongtongJin and mxsm March 16, 2023 03:37
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@RongtongJin RongtongJin merged commit 6fd1bb9 into apache:develop Mar 16, 2023
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
apache#6359)

* docs(controller): add chinese docs about persistent-unique-broker-id

1. add chinese docs about persistent-unique-broker-id

* docs(controller): optimize style in docs: persistent-unique-broker-id.md

1. optimize style in docs: persistent-unique-broker-id.md

* docs(controller): remove test in docs: persistent-unique-broker-id.md

1. remove test in docs: persistent-unique-broker-id.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add chinese docs about persistent-unique-broker-id
4 participants