-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #6358]Add chinese docs about persistent-unique-broker-id #6359
[ISSUE #6358]Add chinese docs about persistent-unique-broker-id #6359
Conversation
1. add chinese docs about persistent-unique-broker-id
1. optimize style in docs: persistent-unique-broker-id.md
Codecov Report
@@ Coverage Diff @@
## develop #6359 +/- ##
=============================================
- Coverage 43.00% 42.99% -0.02%
+ Complexity 8897 8891 -6
=============================================
Files 1103 1103
Lines 77839 77839
Branches 10134 10134
=============================================
- Hits 33472 33463 -9
- Misses 40176 40181 +5
- Partials 4191 4195 +4 see 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheR1sing3un 文档的结构标题排版需要在处理一下,以及后面的这个图片需要重新整理一下。看起来更加正式一点
docs/cn/image/controller/persistent_unique_broker_id/normal_restart.png
Outdated
Show resolved
Hide resolved
docs/cn/image/controller/persistent_unique_broker_id/test_1.png
Outdated
Show resolved
Hide resolved
docs/cn/image/controller/persistent_unique_broker_id/test_10.png
Outdated
Show resolved
Hide resolved
docs/cn/image/controller/persistent_unique_broker_id/test_12.png
Outdated
Show resolved
Hide resolved
docs/cn/image/controller/persistent_unique_broker_id/test_13.png
Outdated
Show resolved
Hide resolved
docs/cn/image/controller/persistent_unique_broker_id/test_14.png
Outdated
Show resolved
Hide resolved
1. remove test in docs: persistent-unique-broker-id.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
apache#6359) * docs(controller): add chinese docs about persistent-unique-broker-id 1. add chinese docs about persistent-unique-broker-id * docs(controller): optimize style in docs: persistent-unique-broker-id.md 1. optimize style in docs: persistent-unique-broker-id.md * docs(controller): remove test in docs: persistent-unique-broker-id.md 1. remove test in docs: persistent-unique-broker-id.md
Make sure set the target branch to
develop
What is the purpose of the change
closes Add chinese docs about persistent-unique-broker-id #6358
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.