Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][feature][Bug] Add Tooltip and Fix Design Issue In the Task Definition #171

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

SachinS10-lab
Copy link
Contributor

[Bug]

When screen height is reduced or more items added in the task synchronization definition sidebar, tiles are falls out of the task synchronization definition sidebar.

Screenshot 2024-08-02 at 11 11 33 AM

Purpose of this pull request

This PR aims to enhance user experience by improving navigation through the task synchronization process and Fixed the above mentioned bug.

Changes Introduced:
Tooltips for Task Tiles : Added tooltips to the Source, Sink, and Transform tiles in the task synchronization definition sidebar. The tooltips provide guidance on dragging and configuring the tiles.
Bug Fix : Addressed a bug that affected the display of the sidebar when the screen height was reduced or when more items were added.

How It Works:
Hover Over Info Icon : When hovering over the Info icon added to the right side of the task synchronization definition sidebar tiles, a tooltip will appear with helpful instructions.
After Dragging Tiles : When dragging Source, Sink, or Transform tiles onto the canvas and selecting them, hovering over the tile will display a tooltip with additional instructions.

Additional Notes:
This is my first pull request. I would appreciate any comments, suggestions, or advice to improve it.

Check list

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 7, 2024

cc @arshadmohammad

@SachinS10-lab
Copy link
Contributor Author

Hi @Hisoka-X,
I'm unable to address this Issue. Could please explain what is happening? How Can I Overcome this Issue?

cc @arshadmohammad

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 7, 2024

Please try merge from main.

@SachinS10-lab
Copy link
Contributor Author

Hi @Hisoka-X, I've merged from main. Could you please rerun the checks.

@SachinS10-lab
Copy link
Contributor Author

Thanks @Hisoka-X

@Hisoka-X Hisoka-X requested a review from arshadmohammad August 7, 2024 10:41
@arshadmohammad
Copy link
Collaborator

Thanks @SachinS10-lab for raising this PR. I will review it.
Meanwhile can you please remove the extra commit from your PR.

@Hisoka-X
Copy link
Member

Hisoka-X commented Aug 8, 2024

cc @baicie

@SachinS10-lab
Copy link
Contributor Author

@arshadmohammad. Sorry for the delay. Is it really needed to remove one commit?

@Hisoka-X
Copy link
Member

@arshadmohammad. Sorry for the delay. Is it really needed to remove one commit?

IMO, unnecessary. We will execute squash and merge when merge to dev.
image

Copy link
Collaborator

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@Hisoka-X Hisoka-X merged commit ec3e655 into apache:main Aug 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants