[Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arshadmohammad
force-pushed
the
integrationTest
branch
from
70080c0 to
0115359
Compare
arshadmohammad
force-pushed
the
integrationTest
branch
from
0115359 to
a0224b6
Compare
|
Added 31 test cases also. All are passing |
|
Great! Thanks @arshadmohammad ! |
|
Great idea |
Hisoka-X
reviewed
Aug 14, 2024
| Build seatunnel-web | ||
| ./mvnw clean install -DskipTests | ||
|
|
||
| Update mysql database details in src/test/resources/application.yml and Run the seatunnel-web-it integration tests |
There was a problem hiding this comment.
How about add mysql environment in e2e? We have some example in https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/MysqlCDCIT.java#L107
There was a problem hiding this comment.
Good suggestion.
Sure, we can add mysql environment in e2e test cases, but later and in separate PR.
Hisoka-X
approved these changes
Aug 14, 2024
|
Thanks @arshadmohammad |
|
Thanks @davidzollo and @hailin0 for the reviewing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to support run test cases in live seatunnel and seatunnel-web. Please go through seatunnel-web-it/README.md to know how to run these integration tests.
Purpose of this pull request
Check list
New License Guide