-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][SeaTunnel-Web] Change JobStatus to enum type to avoid hard coding #205
Conversation
Please fix ci. cc @arshadmohammad |
@Hisoka-X @arshadmohammad PTAL, thanks |
Many integration tests will fail after this change. @wuchunfu can you run the integration tests. Here is the command to run the integration tests ./mvnw -T 1C -B verify -DskipUT=true -DskipIT=false -DSEATUNNEL_HOME=/some/path/apache-seatunnel-2.3.7 -DST_WEB_BASEDIR_PATH=seatunnel-web-dist/target/apache-seatunnel-web-1.0.2-SNAPSHOT/apache-seatunnel-web-1.0.2-SNAPSHOT |
@arshadmohammad Thank you for your review. My testing is normal. Are you sure it was caused by my changes? If that's the case, is there a problem with CI? Can you fix it? |
We didn't bring test case into ci at now. We should add it. |
@wuchunfu In your attached snapshot I can not see how many tests are run, how many failed or passed, can you please attach snapshot like below Here I can see 42 tests are run, 0 failed, 0 error, 0 skipped. |
Hi @arshadmohammad , does our test case need rely mysql container? If not, let me add it into ci. |
The integration test cases are dependent on both MySQL and the Seatunnel-Engine.
|
Thanks @arshadmohammad ! You can refer https://github.com/apache/seatunnel/blob/dev/.github/workflows/build_main.yml and apache/seatunnel#5495. We implemented the logic to run CI in forked repositories so that devs can trigger CI themselves instead of maintainers manually triggering it every time.
Yes, we can use github action |
3f2d819
to
1f21f24
Compare
@arshadmohammad PTAL, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Purpose of this pull request
Change JobStatus to enum type to avoid hard coding
Check list
New License Guide