Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Eric <gaojun2048@gmail.com>
  • Loading branch information
Hisoka-X and EricJoy2048 authored Nov 11, 2022
1 parent 13cddfd commit 3676a44
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion seatunnel-connectors-v2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ retry can work normally.

### TableSourceFactory and TableSinkFactory

In order to automatically create a Source or Sink, it also supports automatic return of the parameters
In order to automatically create the Source Connector and Sink Connector and Transform Connector, we need the connector to return the parameters needed to create them and the verification rules for each parameter. For Source Connector and Sink Connector, we define `TableSourceFactory` and `TableSinkFactory`
supported by the current connector and the required parameters. We define TableSourceFactory and TableSinkFactory,
It is recommended to put it in the same directory as the implementation class of SeaTunnelSource or SeaTunnelSink for easy searching.

Expand Down
2 changes: 1 addition & 1 deletion seatunnel-connectors-v2/README.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Sink可以根据组件属性进行选择,到底是只实现`SinkCommitter`或`

### TableSourceFactory 和 TableSinkFactory

为了实现自动化的创建Source或者Sink,同时支持自动返回当前连接器支持的参数和所需的参数。我们定义了TableSourceFactory和TableSinkFactory,
为了实现自动化的创建Source或者Sink,我们需要连接器能够声明并返回创建他们所需要的参数列表和每个参数的校验规则。为了实现这个目标,我们定义了TableSourceFactory和TableSinkFactory,
建议将其放在和SeaTunnelSource或SeaTunnelSink实现类同一目录下,方便寻找。

- `factoryIdentifier` 用于表明当前Factory的名称,这个值应该和`getPluginName`返回的值一致,这样后续如果使用Factory来创建Source/Sink,
Expand Down

0 comments on commit 3676a44

Please sign in to comment.