[Improve] [Connector-V2] Optimize milvus-connector config code (#7658)

apache · Sep 13, 2024 · f831f7a · f831f7a
1 parent 70ec59c
commit f831f7a
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 29 deletions.
diff --git a/...main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusCommonConfig.java b/...main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusCommonConfig.java
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.milvus.config;
+
+import org.apache.seatunnel.api.configuration.Option;
+import org.apache.seatunnel.api.configuration.Options;
+
+public abstract class MilvusCommonConfig {
+
+    public static final String CONNECTOR_IDENTITY = "Milvus";
+
+    public static final Option<String> URL =
+            Options.key("url")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription("Milvus public endpoint");
+
+    public static final Option<String> TOKEN =
+            Options.key("token")
+                    .stringType()
+                    .noDefaultValue()
+                    .withDescription("Milvus token for authentication");
+}
diff --git a/...c/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSinkConfig.java b/...c/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSinkConfig.java
@@ -28,21 +28,7 @@
 import static org.apache.seatunnel.api.sink.DataSaveMode.DROP_DATA;
 import static org.apache.seatunnel.api.sink.DataSaveMode.ERROR_WHEN_DATA_EXISTS;
 
-public class MilvusSinkConfig {
-
-    public static final String CONNECTOR_IDENTITY = "Milvus";
-
-    public static final Option<String> URL =
-            Options.key("url")
-                    .stringType()
-                    .noDefaultValue()
-                    .withDescription("Milvus public endpoint");
-
-    public static final Option<String> TOKEN =
-            Options.key("token")
-                    .stringType()
-                    .noDefaultValue()
-                    .withDescription("Milvus token for authentication");
+public class MilvusSinkConfig extends MilvusCommonConfig {
 
     public static final Option<String> DATABASE =
             Options.key("database").stringType().noDefaultValue().withDescription("database");

diff --git a/...main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSourceConfig.java b/...main/java/org/apache/seatunnel/connectors/seatunnel/milvus/config/MilvusSourceConfig.java
@@ -20,19 +20,7 @@
 import org.apache.seatunnel.api.configuration.Option;
 import org.apache.seatunnel.api.configuration.Options;
 
-public class MilvusSourceConfig {
-
-    public static final Option<String> URL =
-            Options.key("url")
-                    .stringType()
-                    .noDefaultValue()
-                    .withDescription("Milvus public endpoint");
-
-    public static final Option<String> TOKEN =
-            Options.key("token")
-                    .stringType()
-                    .noDefaultValue()
-                    .withDescription("Milvus token for authentication");
+public class MilvusSourceConfig extends MilvusCommonConfig {
 
     public static final Option<String> DATABASE =
             Options.key("database")

diff --git a/...s/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/source/MilvusSource.java b/...s/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/source/MilvusSource.java
@@ -27,6 +27,7 @@
 import org.apache.seatunnel.api.table.catalog.CatalogTable;
 import org.apache.seatunnel.api.table.catalog.TablePath;
 import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.connectors.seatunnel.milvus.config.MilvusSourceConfig;
 import org.apache.seatunnel.connectors.seatunnel.milvus.convert.MilvusConvertUtils;
 
 import java.util.ArrayList;
@@ -77,6 +78,6 @@ public SourceSplitEnumerator<MilvusSourceSplit, MilvusSourceState> restoreEnumer
 
     @Override
     public String getPluginName() {
-        return "Milvus";
+        return MilvusSourceConfig.CONNECTOR_IDENTITY;
     }
 }