[api-draft][catalog] jdbc catalog #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashulin
force-pushed
the
jdbc-catalog
branch
2 times, most recently
from
ef709b8 to
42d359c
Compare
# Conflicts: # seatunnel-connectors/seatunnel-connectors-seatunnel/pom.xml
Hisoka-X
reviewed
Jun 24, 2022
| @@ -514,6 +515,13 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Hi, I didn't find the reason about add this dependency
There was a problem hiding this comment.
This is added in dependencyManagement.
I expect the new module to be tested using junit5, using @ParameterizedTest, @EnabledOnOs, etc
There was a problem hiding this comment.
I added some parameterized test cases.
There was a problem hiding this comment.
If we use junit5, can we remove older version from pom?
There was a problem hiding this comment.
If we remove junit4, we need to modify the code of the old API. Are we going to do this?
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java
Outdated
Show resolved
Hide resolved
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jun 28, 2022
* [api-draft][catalog] jdbc catalog # Conflicts: # seatunnel-connectors/seatunnel-connectors-seatunnel/pom.xml * [api-draft][catalog] Add AbstractJdbcCatalog with defaultUrl constructor Co-authored-by: Hisoka <fanjiaeminem@qq.com>
lhyundeadsoul
pushed a commit
to lhyundeadsoul/incubator-seatunnel
that referenced
this pull request
Jun 28, 2022
* [api-draft][catalog] jdbc catalog # Conflicts: # seatunnel-connectors/seatunnel-connectors-seatunnel/pom.xml * [api-draft][catalog] Add AbstractJdbcCatalog with defaultUrl constructor Co-authored-by: Hisoka <fanjiaeminem@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
add jdbc catalog
Check list
New License Guide