Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector-v1][doc]Fix inconsistency between document and code logic #2776

Merged
merged 5 commits into from
Sep 19, 2022

Conversation

laglangyue
Copy link
Contributor

@laglangyue laglangyue commented Sep 18, 2022

Purpose of this pull request

#2742

Check list

@laglangyue
Copy link
Contributor Author

The description of the document is a little vague, which makes it easy for users to step on it

@laglangyue
Copy link
Contributor Author

close #2742

docs/en/connector/sink/Jdbc.mdx Outdated Show resolved Hide resolved

if `customUpdateStmt` is empty ,the sql will auto-generate for all columns, else use your sql which refer to the usage of
`INSERT INTO table (...) values (...) ON DUPLICATE KEY UPDATE... ` of `mysql` , use placeholders or fixed values in `values`
tips: the tableName of sql should be consistent with the dbName.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the meaning of this? Do you mean that the table in sql statement should be consistent with dbTable? If so, please describe it more clearly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

  1. In many scenarios, do not need to customize the updateSQL, which can be generated automatically. In addition, user-defined sql is prone to exceptions that the number of parameters does not match.

  2. If need customize SQL exactly, the table name of SQL should be consistent with that of dbTable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, but in your description. it's dbName

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake,I fix it.

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@EricJoy2048 EricJoy2048 merged commit cccfa88 into apache:dev Sep 19, 2022
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Sep 21, 2022
…pache#2776)

* fix connector-v1 jdbc doc exception

Co-authored-by: laglangyue <laglanyue@foxmail.com>
@laglangyue laglangyue deleted the fix_connector-v1 branch October 17, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants