Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][e2e][jdbc] fix some error when docker version is old #2907

Merged
merged 12 commits into from
Oct 6, 2022
Merged

[hotfix][e2e][jdbc] fix some error when docker version is old #2907

merged 12 commits into from
Oct 6, 2022

Conversation

liugddx
Copy link
Member

@liugddx liugddx commented Sep 27, 2022

close #2905

Purpose of this pull request

run JdbcMysqlIT and JdbcPostgresIT ,some error will happen,and the resion is docker version is old.

refer to
https://stackoverflow.com/questions/69706677/cannot-start-postgresql-docker-container-docker-entrypoint-initdb-d-oper
https://hub.docker.com/layers/bitnami/mysql/8.0.29/images/sha256-15b89acd8f2971ea127934a186e6d2483b97ffe325619d8b1bc747b303636f57?context=explore

Check list

@liugddx liugddx changed the title fix some error when docker version is old [hotfix][e2e][jdbc] fix some error when docker version is old Sep 27, 2022
@liugddx liugddx mentioned this pull request Sep 27, 2022
Merged
3 tasks
@EricJoy2048 EricJoy2048 mentioned this pull request Sep 27, 2022
Closed
3 tasks
CalvinKirs
CalvinKirs previously approved these changes Sep 27, 2022
View reviewed changes
@CalvinKirs
Copy link
Member

I see some error log JdbcPostgresIT.testJdbcPostgresSourceAndSinkXA:151 SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".

@CalvinKirs
Copy link
Member

you'll need to update Docker, runc, and likely libseccomp on your host.
But this PR does have some optimizations and I think this change ok.

@liugddx
Copy link
Member Author

liugddx commented Sep 27, 2022

you'll need to update Docker, runc, and likely libseccomp on your host. But this PR does have some optimizations and I think this change ok.
Yeah,i found some problems when running JdbcMysqlIT,i will fix it

@liugddx
Copy link
Member Author

liugddx commented Sep 27, 2022

please rerun CI. @EricJoy2048

@liugddx
Copy link
Member Author

liugddx commented Sep 28, 2022

PTAL thanks . @CalvinKirs @EricJoy2048

hailin0
hailin0 reviewed Sep 28, 2022
View reviewed changes
...l-translation-base/src/main/java/org/apache/seatunnel/translation/source/ParallelSource.java Outdated
executorService = ThreadPoolExecutorFactory.createScheduledThreadPoolExecutor(1, String.format("parallel-split-enumerator-executor-%s", subtaskId));
splitEnumerator.open();
if (restoredSplitState.size() > 0) {
splitEnumerator.addSplitsBack(restoredSplitState, subtaskId);
}
reader.open();
parallelEnumeratorContext.register();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove it?

@ashulin please help to review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should revert？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change it?
I have the same question.

@liugddx liugddx requested review from CalvinKirs and ashulin and removed request for CalvinKirs September 28, 2022 13:28
@liugddx
Copy link
Member Author

liugddx commented Sep 30, 2022

PTAL. @TyrantLucifer @CalvinKirs .

@liugddx liugddx closed this Oct 4, 2022
@liugddx liugddx deleted the bugfix-e2e branch October 4, 2022 13:25
@liugddx liugddx restored the bugfix-e2e branch October 4, 2022 14:55
@liugddx liugddx reopened this Oct 4, 2022
@liugddx liugddx requested review from CalvinKirs and removed request for ashulin October 6, 2022 02:28
@liugddx
Copy link
Member Author

liugddx commented Oct 6, 2022

@EricJoy2048 help to review. I'm using a old version docker environment.Now a little pretty vexed

ashulin
ashulin approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ashulin ashulin merged commit 4c76129 into apache:dev Oct 6, 2022
@liugddx liugddx deleted the bugfix-e2e branch October 8, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hailin0 hailin0 hailin0 left review comments

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@ashulin ashulin ashulin approved these changes

Assignees
No one assigned
Labels
improve
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [e2e] Postgres and mysql container Operation not permitted
4 participants
@liugddx @CalvinKirs @hailin0 @ashulin