Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Connector-V2] [Test] Fix Iceberg test with time type on spark #3183

Merged
merged 7 commits into from
Oct 28, 2022
Merged

[Connector-V2] [Test] Fix Iceberg test with time type on spark #3183

merged 7 commits into from
Oct 28, 2022

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Remove time type on spark test. The test will failed if not.

Check list

@Hisoka-X Hisoka-X mentioned this pull request Oct 25, 2022
Merged
3 tasks
@Hisoka-X
Copy link
Member Author

@hailin0 PTAL

@Hisoka-X Hisoka-X mentioned this pull request Oct 25, 2022
Merged
3 tasks
hailin0
hailin0 previously approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZex
Copy link
Contributor

TaoZex commented Oct 26, 2022

#3189
I tried to deprecate this e2e, but workflow still failed.

@Hisoka-X
Copy link
Member Author

#3189 I tried to deprecate this e2e, but workflow still failed.

Yes, have another problem, we will fix it both in this PR.

@EricJoy2048 EricJoy2048 reopened this Oct 26, 2022
@Hisoka-X Hisoka-X mentioned this pull request Oct 27, 2022
Merged
3 tasks
@liugddx liugddx mentioned this pull request Oct 27, 2022
Closed
3 tasks
EricJoy2048
EricJoy2048 approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

ic4y
ic4y approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@ic4y ic4y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ic4y ic4y merged commit f6da1a9 into apache:dev Oct 28, 2022
@TaoZex TaoZex mentioned this pull request Oct 28, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ic4y ic4y ic4y approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hisoka-X @TaoZex @hailin0 @EricJoy2048 @ic4y