Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]Remove ConnectorV1 from the dev branch #3450

Merged
merged 9 commits into from
Nov 17, 2022
Merged

[Chore]Remove ConnectorV1 from the dev branch #3450

merged 9 commits into from
Nov 17, 2022

Conversation

CalvinKirs
Copy link
Member

V1 has not been updated for a long time, and it has also tended to be stable.
As a development branch, we are currently focusing on V2-related development, so I will remove it from dev branch.

V1 has not been updated for a long time, and it has also tended to be stable.
As a development branch, we are currently focusing on V2-related development, so I will remove it from dev branch.
@CalvinKirs CalvinKirs added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Nov 16, 2022
@CalvinKirs CalvinKirs added License connectors-v1 SeaTunnel connectors, include sink, source labels Nov 16, 2022
@CalvinKirs CalvinKirs requested review from EricJoy2048 and TyrantLucifer and removed request for EricJoy2048 November 16, 2022 09:38
pom.xml Show resolved Hide resolved
@CalvinKirs CalvinKirs changed the title [Chore]Remove ConnectorV 1 from the dev branch [Chore]Remove ConnectorV1 from the dev branch Nov 17, 2022
EricJoy2048
EricJoy2048 previously approved these changes Nov 17, 2022
@hailin0
Copy link
Member

hailin0 commented Nov 17, 2022

Please check update the following files:

bin/install-plugin.sh
plugin-mapping.properties

@CalvinKirs
Copy link
Member Author

Please check update the following files:

bin/install-plugin.sh plugin-mapping.properties

Thx, update plugin-mapping.properties, As for bin/install-plugin.sh, I suggest we keep it, if some user wants to choose to mix, he can still do so, copy start (v1) and connector jar to lib, WDYT?

@hailin0
Copy link
Member

hailin0 commented Nov 17, 2022

Please check update the following files:
bin/install-plugin.sh plugin-mapping.properties

Thx, update plugin-mapping.properties, As for bin/install-plugin.sh, I suggest we keep it, if some user wants to choose to mix, he can still do so, copy start (v1) and connector jar to lib, WDYT?

Please revert plugin-mapping.properties update, if you consider mixed use

@CalvinKirs
Copy link
Member Author

Please check update the following files:
bin/install-plugin.sh plugin-mapping.properties

Thx, update plugin-mapping.properties, As for bin/install-plugin.sh, I suggest we keep it, if some user wants to choose to mix, he can still do so, copy start (v1) and connector jar to lib, WDYT?

Please revert plugin-mapping.properties update, if you consider mixed use

revert. But it doesn't really matter. I don't recommend maintaining this in dev. If necessary, a better way is to add it yourself. After all, we no longer intend to maintain this, we just provide a hybrid method.

@hailin0
Copy link
Member

hailin0 commented Nov 17, 2022

Please check update .github/workflows/*.yml

Copy link
Contributor

@dijiekstra dijiekstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dijiekstra dijiekstra merged commit e294ce2 into apache:dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. connectors-v1 SeaTunnel connectors, include sink, source License reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants