Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] [Connector-V2] Remove Clickhouse Fields Config #3826

Merged
merged 6 commits into from
Jan 9, 2023
Merged

[Improve] [Connector-V2] Remove Clickhouse Fields Config #3826

merged 6 commits into from
Jan 9, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Check list

@Hisoka-X Hisoka-X requested a review from hailin0 December 29, 2022 07:55
@Hisoka-X Hisoka-X linked an issue Dec 29, 2022 that may be closed by this pull request
[Bug] [Connector-V2] [Clickhouse-Sink] sink to clickhouse cluster error #3712
Closed
3 tasks
hailin0
hailin0 previously approved these changes Dec 31, 2022
View reviewed changes
Copy link
Member

@hailin0 hailin0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ci error

.../connectors/seatunnel/clickhouse/sink/client/executor/JdbcBatchStatementExecutorBuilder.java Show resolved Hide resolved
.../connectors/seatunnel/clickhouse/sink/client/executor/JdbcBatchStatementExecutorBuilder.java Show resolved Hide resolved
@hailin0 hailin0 dismissed their stale review December 31, 2022 16:23

please fix ci error

@hailin0
Copy link
Member

hailin0 commented Jan 3, 2023

please fix ci error @Hisoka-X

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Jan 3, 2023

please fix ci error @Hisoka-X

Doing.

@Hisoka-X Hisoka-X requested a review from hailin0 January 3, 2023 07:23
TaoZex
TaoZex approved these changes Jan 7, 2023
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@CalvinKirs CalvinKirs merged commit 74704c3 into apache:dev Jan 9, 2023
@Hisoka-X Hisoka-X deleted the clickhouse_field_match branch January 17, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoZex TaoZex TaoZex approved these changes

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] [Connector-V2] [Clickhouse-Sink] sink to clickhouse cluster error
4 participants
@Hisoka-X @hailin0 @CalvinKirs @TaoZex