-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] JVM parameters distinguish between client and server #4297
Conversation
@EricJoy2048 I made a simple distinction so that there would be two configuration files under config, and starting the client or server would read the respective jvm configuration files. I'm not sure if it's appropriate. |
Offer the test snapshot images to verify you change has worked. You can compile the whole project and change the different jvm parameter between client and server. |
The historical e2e is enough to cover the current changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Hi, please add default jvm heap size with 128M for client. |
bc6bfc6
@TyrantLucifer @Hisoka-X @EricJoy2048 Thanks for your review,I have made the changes. |
* [bug] JVM parameters distinguish between client and server
Purpose of this pull request
Check list
New License Guide
release-note
.