Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-v2][JdbcSink]Fix max_retries default value. #4318

Closed
wants to merge 2 commits into from

Conversation

lightzhao
Copy link
Contributor

Purpose of this pull request

Check list

@TyrantLucifer
Copy link
Member

Merge dev branch in your branch and try againe. Every pull reqeust before merged should pass all CI/CD.

@lightzhao
Copy link
Contributor Author

Merge dev branch in your branch and try againe. Every pull reqeust before merged should pass all CI/CD.

Before submitted the pr, I already pulled the branch created by the latest code.

@lightzhao
Copy link
Contributor Author

@TyrantLucifer @Hisoka-X @ic4y @ashulin PTAL.

@ic4y
Copy link
Contributor

ic4y commented Mar 20, 2023

@lightzhao
Copy link
Contributor Author

If the JDBC sink is IS_EXACTLY_ONCE, max_retries=0 is required, so the default value is 0.

https://github.com/apache/incubator-seatunnel/blob/40699b660cfecb5cffb2da0a94dc1bbd29a19579/seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/sink/JdbcExactlyOnceSinkWriter.java#L77-L87

You need to think about this.

The default value in the document is 3, the document is wrong, and the document needs to be modified.
image

@ic4y
Copy link
Contributor

ic4y commented Mar 21, 2023

@lightzhao You are right, you can submit another pr to fix it

@lightzhao
Copy link
Contributor Author

@lightzhao You are right, you can submit another pr to fix it

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants