-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug][flink-runtime][connectors-v2] Flink register table Environment The running mode is set tojob.mode
#4826
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
cc01a52
[Bug][flink-runtime][connectors-v2] flink registry running mode chang…
zhilinli123 65797f5
[Improve][conf-files][format]Format the.conf file in the same style
zhilinli123 4836020
[Bug][flink-runtime][connectors-v2] Flink register table Environment …
zhilinli123 5ac1b00
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 9ec01fc
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 5bd84bb
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 482e91d
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 01f5c20
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 0aedd26
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 0e358ba
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 de5937d
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 baeb4b1
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 0ff1ba4
Merge branch 'apache:dev' into fix-flink-2pc-runmode-set
zhilinli123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -71,13 +71,17 @@ public List<DataStream<Row>> execute(List<DataStream<Row>> upstreamDataStreams) | |||||||||||||
} else { | ||||||||||||||
sourceFunction = new SeaTunnelParallelSource(internalSource); | ||||||||||||||
} | ||||||||||||||
boolean bounded = | ||||||||||||||
internalSource.getBoundedness() | ||||||||||||||
== org.apache.seatunnel.api.source.Boundedness.BOUNDED | ||||||||||||||
? true | ||||||||||||||
: false; | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||||||||||||||
DataStreamSource<Row> sourceStream = | ||||||||||||||
addSource( | ||||||||||||||
executionEnvironment, | ||||||||||||||
sourceFunction, | ||||||||||||||
"SeaTunnel " + internalSource.getClass().getSimpleName(), | ||||||||||||||
internalSource.getBoundedness() | ||||||||||||||
== org.apache.seatunnel.api.source.Boundedness.BOUNDED); | ||||||||||||||
bounded); | ||||||||||||||
Config pluginConfig = pluginConfigs.get(i); | ||||||||||||||
if (pluginConfig.hasPath(CommonOptions.PARALLELISM.key())) { | ||||||||||||||
int parallelism = pluginConfig.getInt(CommonOptions.PARALLELISM.key()); | ||||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reconfirmed that there is no such problem, I have restored it