Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] [InfluxDBSource] Resolve invalid SQL in initColumnsIndex method caused by direct QUERY_LIMIT appendage with 'tz' function. #4829

Merged
merged 10 commits into from
Nov 27, 2023

Conversation

zhengyuan-cn
Copy link
Contributor

@zhengyuan-cn zhengyuan-cn commented May 25, 2023

recommit RP for [Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231

Purpose of this pull request

Check list

…ex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT apache#4231
@ic4y ic4y changed the title [Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231 [BugFix] [InfluxDBSource] Resolve invalid SQL in initColumnsIndex method caused by direct QUERY_LIMIT appendage with 'tz' function. Aug 5, 2023
@ic4y
Copy link
Contributor

ic4y commented Aug 5, 2023

@Hisoka-X Can you help figure out why there's no CI/CD?
image

@ic4y ic4y closed this Aug 5, 2023
@ic4y ic4y reopened this Aug 5, 2023
@ic4y
Copy link
Contributor

ic4y commented Aug 5, 2023

@Hisoka-X Can you help figure out why there's no CI/CD? image

It's alright now, just close and reopen the PR.

@ic4y
Copy link
Contributor

ic4y commented Aug 5, 2023

@zhengyuan-cn Please use mvn spotless:apply to format the code.

@zhengyuan-cn
Copy link
Contributor Author

@zhengyuan-cn Please use mvn spotless:apply to format the code.

OK, formated

@hailin0 hailin0 closed this Oct 25, 2023
@hailin0 hailin0 reopened this Oct 25, 2023
@hailin0
Copy link
Member

hailin0 commented Oct 25, 2023

@zhengyuan-cn

image

@Hisoka-X Hisoka-X added bug First-time contributor First-time contributor labels Oct 27, 2023
@zhengyuan-cn
Copy link
Contributor Author

@Hisoka-X @ic4y @hailin0 all checks have passed, please review code.

@zhengyuan-cn
Copy link
Contributor Author

@Hisoka-X I accidentally clicked on the review request

@Hisoka-X
Copy link
Member

cc @hailin0

@EricJoy2048 EricJoy2048 merged commit deed9c6 into apache:dev Nov 27, 2023
2 checks passed
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
…hod caused by direct QUERY_LIMIT appendage with 'tz' function. (apache#4829)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants