[Improve][Connector-V2][Mongodb]allow null value fields #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liugddx
reviewed
Jun 25, 2023
Comment on lines
107
to
113
| public static final Option<Boolean> ALLOW_NULL = | ||
| Options.key("allow-null") | ||
| .booleanType() | ||
| .defaultValue(false) | ||
| .withDescription("allow null value when fields reading is null"); | ||
|
|
||
| // -------------------------------------------------------------------- |
There was a problem hiding this comment.
Please describe this parameter in the documentation.
https://github.com/apache/seatunnel/blob/dev/docs/en/connector-v2/source/MongoDB.md
liugddx
reviewed
Jun 26, 2023
| @@ -85,6 +85,7 @@ Source Options | |||
| | fetch.size | Int | No | 2048 | Set the number of documents obtained from the server for each batch. Setting the appropriate batch size can improve query performance and avoid the memory pressure caused by obtaining a large amount of data at one time. | | |||
| | max.time-min | Long | No | 600 | This parameter is a MongoDB query option that limits the maximum execution time for query operations. The value of maxTimeMin is in Minute. If the execution time of the query exceeds the specified time limit, MongoDB will terminate the operation and return an error. | | |||
| | flat.sync-string | Boolean | No | true | By utilizing flatSyncString, only one field attribute value can be set, and the field type must be a String. This operation will perform a string mapping on a single MongoDB data entry. | | |||
| | allow-null | Boolean | No | false | If set to true, exceptions will be ignored if a null value is encountered. | | |||
|
@MonsterChenzhuo PTAL |
|
Please add the corresponding e2e test. |
|
would you please tell me how to run e2e locally? error happened when using |
|
I think you need run |
…ache#4962) Co-authored-by: chenzy15 <chenzy15@ziroom.com>
Co-authored-by: wsstony <tonymao777@163.com>
Co-authored-by: lightzhao <zhaolianyong777@gmail.com>
…he#4964) * [Improve][Connector-V2][Jindo-Oss] Optimize jindo-oss connector * [Improve][Connector-V2][Jindo-Oss] Update module name * [Hotfix][Connector-V2][StarRocks] Fix code style
… SQL Transform plugin (apache#4991) Co-authored-by: mcy <rewrma@163.com>
Co-authored-by: chenqqq11 <chenzy15@ziroom.com>
|
"==> expected: <0> but was: <1> Please fix the e2e issue. |
3 tasks
3 tasks
|
Please fix conflicts |
|
Hi, Are there any latest developments regarding this PR? At present, it has been at least two weeks without any new changes |
|
any process? |
1 similar comment
|
If this problem still exists, I will try to fix it |
|
fixed by #6967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.