[Improve][Docs] Refactor MySQL-CDC docs #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-reformat-mysql-cdc-docs
branch
from
8eaa8f1 to
586f3e4
Compare
hailin0
commented
Aug 14, 2023
| @@ -81,18 +85,6 @@ public OptionRule optionRule() { | |||
| StopMode.SPECIFIC, | |||
| SourceOptions.STOP_SPECIFIC_OFFSET_FILE, | |||
| SourceOptions.STOP_SPECIFIC_OFFSET_POS) | |||
| .conditional( | |||
There was a problem hiding this comment.
remove unsupport options
| @@ -87,9 +92,10 @@ public static SeaTunnelDataType<?> convertFromColumn(Column column) { | |||
| case MYSQL_BIT: | |||
| return BasicType.BOOLEAN_TYPE; | |||
| case MYSQL_TINYINT: | |||
| return column.length() == 1 ? BasicType.BOOLEAN_TYPE : BasicType.INT_TYPE; | |||
| return BasicType.BYTE_TYPE; | |||
There was a problem hiding this comment.
remove unsupported convert
There was a problem hiding this comment.
It came from #5105 , any reason we should remove this? cc @Carl-Zhou-CN
There was a problem hiding this comment.
The read data is not converted according to this mapping...
|
@EricJoy2048 PTAL |
hailin0
force-pushed
the
dev-reformat-mysql-cdc-docs
branch
from
586f3e4 to
4568268
Compare
Hisoka-X
approved these changes
Aug 31, 2023
TyrantLucifer
approved these changes
Aug 31, 2023
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* [Improve][Docs] Refactor MySQL-CDC docs * Update MySqlTypeUtils.java * Update MySQL-CDC.md
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* [Improve][Docs] Refactor MySQL-CDC docs * Update MySqlTypeUtils.java * Update MySQL-CDC.md
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* [Improve][Docs] Refactor MySQL-CDC docs * Update MySqlTypeUtils.java * Update MySQL-CDC.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.