[Bugfix]Fix the problem of "," being divided in [] #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ruanwenjun
reviewed
Aug 30, 2023
...-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/ParameterSplitter.java
Outdated
Show resolved
Hide resolved
| Pattern pattern = Pattern.compile("\\[.*?]|,"); | ||
|
|
||
| @Override | ||
| public List<String> split(String value) { |
There was a problem hiding this comment.
Please add doc and UT for this method, and if the params contains ";" what will happen?
e.g. if the args looks like -i "map = ["par1=20230829;", "par2=20230829;"]"
There was a problem hiding this comment.
Please add doc and UT for this method, and if the params contains ";" what will happen? e.g. if the args looks like -i "map = ["par1=20230829;", "par2=20230829;"]"
Yes, this code has a bug, I modified the implementation.PTAL
…/seatunnel/core/starter/command/ParameterSplitter.java Co-authored-by: Wenjun Ruan <wenjun@apache.org>
ruanwenjun
previously approved these changes
Aug 31, 2023
|
Since the quotes [] cannot be parsed, special processing is required. |
|
@ruanwenjun @EricJoy2048 PTAL |
EricJoy2048
approved these changes
Sep 1, 2023
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* Fix the problem of "," being divided in [] * Update seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/ParameterSplitter.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> * fix error * fix bug * fix bug --------- Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* Fix the problem of "," being divided in [] * Update seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/ParameterSplitter.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> * fix error * fix bug * fix bug --------- Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Zhouwen-CN
pushed a commit
to Zhouwen-CN/seatunnel
that referenced
this pull request
Sep 11, 2023
* Fix the problem of "," being divided in [] * Update seatunnel-core/seatunnel-core-starter/src/main/java/org/apache/seatunnel/core/starter/command/ParameterSplitter.java Co-authored-by: Wenjun Ruan <wenjun@apache.org> * fix error * fix bug * fix bug --------- Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.