-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix log error when multi-table sink close #5683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
reviewed
Oct 23, 2023
...rg/apache/seatunnel/connectors/seatunnel/common/multitablesink/MultiTableWriterRunnable.java
Show resolved
Hide resolved
…che/seatunnel/connectors/seatunnel/common/multitablesink/MultiTableWriterRunnable.java Co-authored-by: Wenjun Ruan <wenjun@apache.org>
ruanwenjun
previously approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hisoka-X
commented
Oct 25, 2023
...va/org/apache/seatunnel/connectors/seatunnel/common/multitablesink/MultiTableSinkWriter.java
Show resolved
Hide resolved
hailin0
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hailin0
approved these changes
Oct 25, 2023
ruanwenjun
approved these changes
Oct 25, 2023
ruanwenjun
pushed a commit
to ruanwenjun/incubator-seatunnel
that referenced
this pull request
Nov 6, 2023
…#468) * [Fix] Fix log error when multi-table sink close (apache#5683) * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix
MultiTableSinkWriter
will log error even job execute successed. This cause byMultiTableWriterRunnable
, it will reportedInterruptedException
sometimes when be closed byExecutorService
. So this PR ignore this Exception when task close. This exception will be like:This bug does not affect the correctness of the job, it just prints confusing error logs in the log.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note
.