-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Rest-API] fix submit job api #5702
Conversation
Could you add a test case for this? Seem like this is a very important feature we shouldn't missed. It's weird we don't have a test case to cover it. cc @liugddx |
reuse the
|
c3dec54
to
36f4cfd
Compare
...2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/RestApiIT.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpPostCommandProcessor.java
Show resolved
Hide resolved
...seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/utils/RestUtil.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @liunaijie for fix! BTW, the test case you added are very important!
Purpose of this pull request
close #5699
Does this PR introduce any user-facing change?
How was this patch tested?
use postman
Check list
New License Guide
release-note
.