Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix MultiTableSink return committer but sink do not support #5710

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Fix the bug when sink return committer/aggcommitter emtpy but MultiTableSink will return multi-table committer/aggcommitter. This PR change this behavior, to make sure MultiTableSink also return empty.

Does this PR introduce any user-facing change?

No

How was this patch tested?

add new test.

Check list

@Hisoka-X Hisoka-X added the bug label Oct 26, 2023
ruanwenjun
ruanwenjun previously approved these changes Oct 26, 2023
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hailin0
Copy link
Member

hailin0 commented Oct 26, 2023

Waiting for ci ok

@wuchunfu wuchunfu merged commit c413040 into apache:dev Oct 27, 2023
@Hisoka-X Hisoka-X deleted the fix-multitable-with-empty-committer branch October 27, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants