Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http #5816

Merged
merged 16 commits into from
Nov 22, 2023
Merged

[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http #5816

merged 16 commits into from
Nov 22, 2023

Conversation

jackyyyyyssss
Copy link
Contributor

@jackyyyyyssss jackyyyyyssss commented Nov 8, 2023 •
edited
Loading

Purpose of this pull request

#5807 #5651 [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http

Does this PR introduce any user-facing change?

How was this patch tested?

improve current e2e test

Check list

@jackyyyyyssss jackyyyyyssss changed the title [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http #5807 [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http Nov 8, 2023
@jackyyyyyssss jackyyyyyssss mentioned this pull request Nov 8, 2023
Open
2 tasks
Hisoka-X
Hisoka-X reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change getProducedType to getProducedCatalogTables in HttpSource. https://github.com/apache/seatunnel/pull/5816/files#diff-7c704c6a3927123b31b41483102f286339da3832309810496f19410c2548f06fR153

@jackyyyyyssss
Copy link
Contributor Author

Please change getProducedType to getProducedCatalogTables in HttpSource. https://github.com/apache/seatunnel/pull/5816/files#diff-7c704c6a3927123b31b41483102f286339da3832309810496f19410c2548f06fR153

done PTAL

Hisoka-X
Hisoka-X reviewed Nov 9, 2023
View reviewed changes
...or-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/sink/HttpSink.java
public void setTypeInfo(SeaTunnelRowType seaTunnelRowType) {
this.seaTunnelRowType = seaTunnelRowType;
public String getPluginName() {
return "Http";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can use CONNECTOR_IDENTITY to replace Http now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

EricJoy2048
EricJoy2048 reviewed Nov 10, 2023
View reviewed changes
...e/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceFactory.java
@@ -49,7 +61,6 @@ public OptionRule.Builder getHttpBuilder() {
.optional(HttpConfig.FORMAT)
.optional(HttpConfig.JSON_FIELD)
.optional(HttpConfig.CONTENT_FIELD)
.conditional(HttpConfig.METHOD, HttpRequestMethod.POST, HttpConfig.BODY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Contributor Author

@jackyyyyyssss jackyyyyyssss Nov 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because when using the params parameter, the post method is also used without a body

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, And you need add HttpConfig.BODY use .optional(HttpConfig.BODY). Otherwise, the body parameter will be lost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done PTAL @EricJoy2048

Hisoka-X
Hisoka-X approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jackyyyyyssss !

@Hisoka-X Hisoka-X merged commit 6f49ec6 into apache:dev Nov 22, 2023
5 checks passed
alextinng pushed a commit to alextinng/seatunnel that referenced this pull request Dec 19, 2023
@jackyyyyyssss @q3356564
[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory o…
92b2345 
…n http (apache#5816)



---------

Co-authored-by: 80597928 <673421862@qq.com>
@jackyyyyyssss jackyyyyyssss deleted the feature_factory branch July 23, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 feature New feature reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackyyyyyssss @EricJoy2048 @Hisoka-X @q3356564