Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Hive-Jdbc use krb5 overwrite kerberosKeytabPath #5891

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[Bug] Fix Hive-Jdbc use krb5 overwrite kerberosKeytabPath #5891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/config/JdbcConnectionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public static JdbcConnectionConfig of(ReadonlyConfig config) {
builder.useKerberos(config.get(JdbcOptions.USE_KERBEROS));
builder.kerberosPrincipal(config.get(JdbcOptions.KERBEROS_PRINCIPAL));
builder.kerberosKeytabPath(config.get(JdbcOptions.KERBEROS_KEYTAB_PATH));
builder.kerberosKeytabPath(config.get(JdbcOptions.KRB5_PATH));
builder.krb5Path(config.get(JdbcOptions.KRB5_PATH));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an improve or a fix?

Copy link
Member Author

@ruanwenjun ruanwenjun Nov 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix, current code uses KRB5_PATH to overwrite kerberosKeytabPath this will cause us to use the incorrect Kerberos configuration to login.

}
config.getOptional(JdbcOptions.USER).ifPresent(builder::username);
config.getOptional(JdbcOptions.PASSWORD).ifPresent(builder::password);
Expand Down